Reviewed-by: Ruiyu Ni <[email protected]> > -----Original Message----- > From: Laszlo Ersek [mailto:[email protected]] > Sent: Friday, July 1, 2016 9:11 AM > To: edk2-devel-01 <[email protected]> > Cc: Johnson, Brian J. <[email protected]>; Alex Williamson > <[email protected]>; Andrew Fish <[email protected]>; Tian, Feng > <[email protected]>; Justen, Jordan L <[email protected]>; Gao, > Liming <[email protected]>; Marcel Apfelbaum <[email protected]>; > Kinney, Michael D <[email protected]>; Ni, Ruiyu > <[email protected]>; Zeng, Star <[email protected]> > Subject: [PATCH 1/4] MdePkg/IndustryStandard: introduce > EFI_PCI_CAPABILITY_ID_SHPC > > The "Pci22.h" header file defines the macro > EFI_PCI_CAPABILITY_ID_HOTPLUG with value 0x06. According to all of: > - later parts of the same header file, > - Appendix H ("Capability IDs") of the PCI Local Bus Specification > Revision 2.3, > - and Chapter 2 ("Capability IDs") of the PCI Code and ID Assignment > Specification Revision 0.9, > > 0x06 means "CompactPCI Hot Swap". It does not mean "PCI Hot-Plug": that > capability is described by ID 0x0C: > > 0Ch PCI Hot-Plug -- This Capability ID indicates that the associated > device conforms to the Standard Hot-Plug Controller model. > > Therefore EFI_PCI_CAPABILITY_ID_HOTPLUG is arguably a misnomer. > PciBusDxe (mis-)uses EFI_PCI_CAPABILITY_ID_HOTPLUG in the IsSHPC() > helper function to identify PCI Hot-Plug capability. > > In order to preserve compatibility with existent code, leave > EFI_PCI_CAPABILITY_ID_HOTPLUG alone, and introduce > EFI_PCI_CAPABILITY_ID_SHPC with the right ID value. > > Cc: "Johnson, Brian J." <[email protected]> > Cc: Alex Williamson <[email protected]> > Cc: Andrew Fish <[email protected]> > Cc: Feng Tian <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Marcel Apfelbaum <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Ruiyu Ni <[email protected]> > Cc: Star Zeng <[email protected]> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <[email protected]> > --- > MdePkg/Include/IndustryStandard/Pci22.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdePkg/Include/IndustryStandard/Pci22.h > b/MdePkg/Include/IndustryStandard/Pci22.h > index db24a153e15e..4cf8389c699b 100644 > --- a/MdePkg/Include/IndustryStandard/Pci22.h > +++ b/MdePkg/Include/IndustryStandard/Pci22.h > @@ -635,6 +635,7 @@ typedef union { > #define EFI_PCI_CAPABILITY_ID_SLOTID 0x04 > #define EFI_PCI_CAPABILITY_ID_MSI 0x05 > #define EFI_PCI_CAPABILITY_ID_HOTPLUG 0x06 > +#define EFI_PCI_CAPABILITY_ID_SHPC 0x0C > > /// > /// Capabilities List Header > -- > 1.8.3.1 >
_______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
