On 2016-06-30 18:10:53, Laszlo Ersek wrote:
> +EFI_STATUS
> +EFIAPI
> +DriverInitialize (
> + IN EFI_HANDLE ImageHandle,
> + IN EFI_SYSTEM_TABLE *SystemTable
> + )
> +{
> + EFI_STATUS Status;
> +
> + if (!FeaturePcdGet (PcdPciBusHotplugDeviceSupport)) {
> + DEBUG ((EFI_D_WARN,
> + "%a: this driver should not have been built into the firmware\n",
> + gEfiCallerBaseName));
> + return EFI_UNSUPPORTED;
> + }
It looks like we'll always have this PCD as true, and always include
the driver. I don't have a concern about that. (Do you know of a
reason that we might need to make it conditional?)
What if we instead add this to PlatformDxe, and either drop, or turn
the PcdPciBusHotplugDeviceSupport check into an ASSERT?
-Jordan
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel
