On Tue, Oct 30, 2012 at 4:46 AM, Laszlo Ersek <ler...@redhat.com> wrote: > comments in-line > On 10/26/12 19:35, Jordan Justen wrote: >> + LastE820 = &Bp->e820_map[0]; > > LastE820 here should be set to NULL... > >> + if ((LastE820 != NULL) && >> + (LastE820->type == (UINT32) E820Type) && > > ... because here "LastE820->type" should not even be investigated unless > we have added at least one entry. (Currently, the contents of *LastE820 > on the first occasion we reach this code is indeterminate, it is > something we copied from the host into the kernel setup buffer via fw_cfg.) > > (I think Matt mentioned something like this last time -- apologies for > not reviewing this function more thoroughly in the v2 posting!)
Ah, I see. Thanks for pointing that out again, and sorry Matt for not looking closely enough at what you meant. -Jordan ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_sfd2d_oct _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
