On Thu, Aug 21, 2014 at 10:34 PM, <reza.jel...@tuhh.de> wrote: > From: Reza Jelveh <reza.jel...@tuhh.de> > > This patch adds apple boot support to Ovmf. It readds the ConsoleControl > protocol and adds firmware and datahub settings apple needs for > successful osx boot. > > This version fixes a few typos throughout the last version and moves the > ConsoleControl protocol from EdkCompat to OvmfPkg > > > Reza Jelveh (4): > OvmfPkg: add ConsoleControl protocol
I think we should add ConsoleControl directly in the library. The library is the only thing that references it, right? Other than XNU? > OvmfPkg: add apple boot support to Ovmf What do you think of calling this XnuCompatLib instead? > OvmfPkg: InitializeAppleSupport from BdsPlatform Could this be initialized in PlatformDxe instead? > OvmfPkg: enable AppleSupport library for Ovmf firmware I think the library needs to be added in the previous patch, or there would be a build error. Hmm, I wonder if a stub DataHub might be able to make the OS happy enough to boot. -Jordan > OvmfPkg/Include/Library/AppleSupportLib.h | 25 +++++ > OvmfPkg/Include/Protocol/ConsoleControl.h | 122 > +++++++++++++++++++++ > OvmfPkg/Library/AppleSupportLib/AppleSupport.c | 107 ++++++++++++++++++ > .../Library/AppleSupportLib/AppleSupportLib.inf | 48 ++++++++ > OvmfPkg/Library/AppleSupportLib/Common.h | 24 ++++ > OvmfPkg/Library/AppleSupportLib/Console.c | 86 +++++++++++++++ > OvmfPkg/Library/AppleSupportLib/Console.h | 28 +++++ > OvmfPkg/Library/AppleSupportLib/Datahub.c | 104 ++++++++++++++++++ > OvmfPkg/Library/AppleSupportLib/Datahub.h | 32 ++++++ > OvmfPkg/Library/PlatformBdsLib/BdsPlatform.c | 5 + > OvmfPkg/Library/PlatformBdsLib/BdsPlatform.h | 1 + > OvmfPkg/Library/PlatformBdsLib/PlatformBdsLib.inf | 1 + > OvmfPkg/OvmfPkg.dec | 1 + > OvmfPkg/OvmfPkgIa32.dsc | 7 ++ > OvmfPkg/OvmfPkgIa32.fdf | 2 + > OvmfPkg/OvmfPkgIa32X64.dsc | 7 ++ > OvmfPkg/OvmfPkgIa32X64.fdf | 2 + > OvmfPkg/OvmfPkgX64.dsc | 7 ++ > OvmfPkg/OvmfPkgX64.fdf | 2 + > 19 files changed, 611 insertions(+) > create mode 100644 OvmfPkg/Include/Library/AppleSupportLib.h > create mode 100644 OvmfPkg/Include/Protocol/ConsoleControl.h > create mode 100644 OvmfPkg/Library/AppleSupportLib/AppleSupport.c > create mode 100644 OvmfPkg/Library/AppleSupportLib/AppleSupportLib.inf > create mode 100644 OvmfPkg/Library/AppleSupportLib/Common.h > create mode 100644 OvmfPkg/Library/AppleSupportLib/Console.c > create mode 100644 OvmfPkg/Library/AppleSupportLib/Console.h > create mode 100644 OvmfPkg/Library/AppleSupportLib/Datahub.c > create mode 100644 OvmfPkg/Library/AppleSupportLib/Datahub.h > > -- > 1.9.2 > > > ------------------------------------------------------------------------------ > Slashdot TV. > Video for Nerds. Stuff that matters. > http://tv.slashdot.org/ > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce. Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel