On Tue, Sep 9, 2014 at 1:23 AM, Reza Jelveh <reza.jel...@tuhh.de> wrote: > On 08/09/14 21:35, Jordan Justen wrote: >> I think we should add ConsoleControl directly in the library. >> >> The library is the only thing that references it, right? Other than XNU? >> > OvmfPkg: InitializeAppleSupport from BdsPlatform >> >> Could this be initialized in PlatformDxe instead? > yes, sorry, i need to finish cleaning up laszlo said it's required to be a dxe > >> > OvmfPkg: add apple boot support to Ovmf >> >> What do you think of calling this XnuCompatLib instead? > Yeah might be a better name. > > >> > OvmfPkg: enable AppleSupport library for Ovmf firmware >> >> I think the library needs to be added in the previous patch, or there >> would be a build error. >> >> Hmm, I wonder if a stub DataHub might be able to make the OS happy >> enough to boot. > The way I understood Laszlos critique was that it shouldn't be a library at > all but a dxemodule with compile time flag, did I misunderstand anything?
Ah, I see Laszlo's recommendation now. Yeah, that would be fine. It looks like you did not yet get a chance to split it out to a separate driver. But, whether you do: * XnuCompatLib called from PlatformDxe, or * XnuCompatDxe ...my question about DataHub still applies. The DataHub is deprecated, so I'm wondering how strongly XNU depends on it. Perhaps it would be fine if it can locate the protocol, but the protocol functions always fail. That is what I meant by a stub DataHub implementation. If the stub idea worked, then it could be another item to lump into XnuCompat. I'm not saying you are required to investigate the XNU DataHub dependency, but adding in this deprecated driver is a bit frustrating. -Jordan ------------------------------------------------------------------------------ Want excitement? Manually upgrade your production database. When you want reliability, choose Perforce Perforce version control. Predictably reliable. http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
