On 08/09/14 21:35, Jordan Justen wrote:
> I think we should add ConsoleControl directly in the library.
> 
> The library is the only thing that references it, right? Other than XNU?
> >   OvmfPkg: InitializeAppleSupport from BdsPlatform
> 
> Could this be initialized in PlatformDxe instead?
yes, sorry, i need to finish cleaning up laszlo said it's required to be a dxe

> >   OvmfPkg: add apple boot support to Ovmf
> 
> What do you think of calling this XnuCompatLib instead?
Yeah might be a better name.


> >   OvmfPkg: enable AppleSupport library for Ovmf firmware
> 
> I think the library needs to be added in the previous patch, or there
> would be a build error.
> 
> Hmm, I wonder if a stub DataHub might be able to make the OS happy
> enough to boot.
The way I understood Laszlos critique was that it shouldn't be a library at
all but a dxemodule with compile time flag, did I misunderstand anything?

------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

Reply via email to