On 2015-05-04 10:48:05, Andrew Fish wrote: > On May 4, 2015, at 10:33 AM, Jordan Justen <jordan.l.jus...@intel.com> > wrote: > On 2015-05-04 08:57:29, Kinney, Michael D wrote: > > Jordan, > > Some source control systems provide support a file type of UTF-16LE, > so the use of 'binary' should be avoided. What source control > systems require the use of 'binary'? > > Svn seems to require it so the data doesn't get munged. > > Git seems to auto-detect UTF-16 .uni files as binary. > > What diff utilities are having issues with UTF-16LE files? Can you > provide some examples? > > I don't think it is possible to create a .uni patch file for EDK II > that actually works. > > Normally, for .uni files we just see something about the diff being > omitted on a binary file. > > With git, I know there are ways to force a diff to be produced, but I > don't believe it would actually work to apply a patch to a UTF-16 > file. > > This > http://stackoverflow.com/questions/777949/can-i-make-git-recognize-a-utf-16-file-as-text > stackoverflow > article seems to imply you can can make git-merge work with a > .gitattributes file setting?
Is there a concern with supporting UTF-8? It seems like in general UTF-8 is better supported, and requires no configuration tweaks. I think the situation is that UTF-8 has become the most commonly used format, and therefore it is the most likely format to work well with tools. For EDK II's needs, I can't see a downside to supporting UTF-8, and it did not require a huge amount of effort. -Jordan > Thanks, > Andrew Fish > > With utf-8, it seems to 'just work'. (With git and svn.) > > Also, what are the pros/cons to extending the exiting .uni file > extension to support either UTF16-LE or UTF-8 encodings vs. adding a > new file extension? > > I don't know of any pros/cons. We could assume that a file without the > UTF-16 BOM is UTF-8. > > It would certainly mess up my unit tests. :) > > -Jordan ------------------------------------------------------------------------------ One dashboard for servers and applications across Physical-Virtual-Cloud Widest out-of-the-box monitoring support with 50+ applications Performance metrics, stats and reports that give you Actionable Insights Deep dive visibility with transaction tracing using APM Insight. http://ad.doubleclick.net/ddm/clk/290420510;117567292;y _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
