On Tue, Jun 23, 2015 at 11:39 AM, Laszlo Ersek <ler...@redhat.com> wrote: > On 06/23/15 20:35, Roy Franz wrote: >> Add a description of how to describe the authorship of a patch that >> is submitted by someone other than the original author. >> Add mention of git format-patch --stat=120 option for generating >> more useful patch names in diffstat. > > FWIW I use: > > --stat=1000 --stat-graph-width=20 > > This makes the pathname column as wide as necessary (but not wider), > while keeping the stats column to the right reasonable.
I will update that (or Michael can when he commits). I recall you posting the format-patch options earlier, but searched the list and couldn't find them, so the --stat=120 was my guess. I figured I'd update the docs so this gets captured someplace that can be found :) > >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Roy Franz <roy.fr...@linaro.org> >> --- >> MdePkg/Contributions.txt | 11 ++++++++++- >> 1 file changed, 10 insertions(+), 1 deletion(-) >> >> diff --git a/MdePkg/Contributions.txt b/MdePkg/Contributions.txt >> index f87cbd7..98de958 100644 >> --- a/MdePkg/Contributions.txt >> +++ b/MdePkg/Contributions.txt >> @@ -67,7 +67,16 @@ Patch content inline or attached >> * The first line of commit message is taken from the email's subject >> line following [PATCH]. The remaining portion of the commit message >> is the email's content until the '---' line. >> -* git format-patch is one way to create this format >> +* git format-patch is one way to create this format. In order to get >> + useful path names in the diffstat, the "--stat=120" option should >> + be used. >> +* If a patch is being submitted by someone other than the orginal >> + author, then the orginal author's Signed-off-by/Contributed-under lines >> + should be first, followed by the Signed-off-by/Contributed-under lines >> + of the patch submitter. Any changes made by the submitter should be >> + noted above the submitter's Signed-off-by line. If git is being used >> + to prepare the patches, the git author of the commit corresponding to >> + the patch should be owned by the original author (git commit --author). > > This matches how I think about it, yes. > > Thanks > Laszlo > >> >> === Definitions for sample patch email === >> >> > ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
