This rule means the submitter is also Signed-off-by. Right? I originally understand Signed-off-by means the patch authors, not submitter. Could you let me why add this new rule?
-----Original Message----- From: Roy Franz [mailto:roy.fr...@linaro.org] Sent: Wednesday, June 24, 2015 2:36 AM To: edk2-devel@lists.sourceforge.net; ler...@redhat.com; Kinney, Michael D Subject: [edk2] [PATCH] MdePkg: Describe submission of a patch authored by someone else Add a description of how to describe the authorship of a patch that is submitted by someone other than the original author. Add mention of git format-patch --stat=120 option for generating more useful patch names in diffstat. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Roy Franz <roy.fr...@linaro.org> --- MdePkg/Contributions.txt | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/MdePkg/Contributions.txt b/MdePkg/Contributions.txt index f87cbd7..98de958 100644 --- a/MdePkg/Contributions.txt +++ b/MdePkg/Contributions.txt @@ -67,7 +67,16 @@ Patch content inline or attached * The first line of commit message is taken from the email's subject line following [PATCH]. The remaining portion of the commit message is the email's content until the '---' line. -* git format-patch is one way to create this format +* git format-patch is one way to create this format. In order to get + useful path names in the diffstat, the "--stat=120" option should + be used. +* If a patch is being submitted by someone other than the orginal + author, then the orginal author's Signed-off-by/Contributed-under +lines + should be first, followed by the Signed-off-by/Contributed-under +lines + of the patch submitter. Any changes made by the submitter should be + noted above the submitter's Signed-off-by line. If git is being used + to prepare the patches, the git author of the commit corresponding to + the patch should be owned by the original author (git commit --author). === Definitions for sample patch email === -- 2.1.4 ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel ------------------------------------------------------------------------------ Monitor 25 network devices or servers for free with OpManager! OpManager is web-based network management software that monitors network devices and physical & virtual servers, alerts via email & sms for fault. Monitor 25 devices for free with no restriction. Download now http://ad.doubleclick.net/ddm/clk/292181274;119417398;o _______________________________________________ edk2-devel mailing list edk2-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/edk2-devel
