On 01/05/2015 04:46 AM, Andrew wrote: > 2015-01-05 6:48 GMT+02:00 Sebastian Kuzminsky <[email protected] > <https://mail.google.com/mail/u/0/?view=cm&fs=1&tf=1&[email protected]>>: >> >> On 12/26/2014 01:49 PM, Andrew wrote: >> > I just found a small error in the config and amended the commit. Sorry. >> > The corrected patch is attached. >> >> Hi Andrew, sorry it's taken me a while to get back to this. >> >> I just applied your patches (i used the second patch you sent me for the >> sample config, from December 26). I played around with the hexapod >> config and it seems to work great as far as i can tell. >> >> Nice work, and thanks for the patches! > > Hello Sebastian, thank you! > > I actually enjoyed the process and I'd like to continue (very slowly) > contributing to genhexkins and its configs. > I could add optional screw lenght compensation for cardanic joints after > it's throughly tested on my machine. > Probably add some pins to adjust position online (could be useful for > homing, but I have to figure it out yet). > I could also share a few realtime configs, e.g. parport stepper and > analog servo. > Though I mostly use configs for joints_axes, they could be reverted. > Please let me know if it's appropriate.
That would be great. I'm glad you're giving nontrivial kinematics a workout, that's an area of LinuxCNC that could sure us a good developer. Any patches in that area would be much appreciated. Also, if you have experiences with both the mainline branches and joints_axes, that's something i'd love to hear about. Do you have a Stewart Platform machine? If so i'd also love to see a video of it! Oh, I should mention that i changed your first commit a tiny bit. You had removed the Copyright lines from genhexkins.[ch], i added them back in. Also, a small request.... Please try to avoid making spurious changes unrelated to your intended change, it makes it harder to review the patch. I highlighted a couple of the instances i stumbled over in your genhexkins.c patch here: https://github.com/jepler/linuxcnc-mirror/commit/0cc3445e1d7fc0a405039d07df6bef8d46b35c29 Those are nitpick-level comments. Thanks again for your patches. -- Sebastian Kuzminsky ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Emc-developers mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/emc-developers
