On 12 January 2014 04:50, Xuejie "Rafael" Xiao <[email protected]> wrote:
> Mark: Thanks a lot for the patch! > > I did some test using the patch. Clang would indeed stop issuing errors, > however, we are still hitting some errors in llvm. A detailed log > containing outputs before and after the patch can be found at here: > https://gist.github.com/xxuejie/8384185. > > So is this because of some restrictions in emscripten-fastcomp? > Good point. I didn't notice that because I didn't test it end-to-end. Here's a fix for the IR simplification passes in the LLVM branch: https://codereview.chromium.org/135953002 Cheers, Mark On Sat, Jan 11, 2014 at 11:39 PM, Mark Seaborn <[email protected]>wrote: > >> On 8 January 2014 15:56, Alon Zakai <[email protected]> wrote: >> >>> If you have a simple solution in mruby source, that would be best for >>> you I think. If not, then we should see about fixing it in clang. My guess >>> is that it is not a deep problem, just a todo, so likely not hard for us to >>> fix. I've not worked on the clang code before though. >>> >>> Mark, do you know if pnacl has plans to fix that issue (2381)? >>> >> >> Since you asked, I've prepared a fix and posted it for review: >> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140106/096991.html >> >> Cheers, >> Mark >> >> -- >> You received this message because you are subscribed to the Google Groups >> "emscripten-discuss" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > -- > You received this message because you are subscribed to the Google Groups > "emscripten-discuss" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "emscripten-discuss" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
