Roy Golan has posted comments on this change.
Change subject: core: Add correlation support to ovirt-engine
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 538: if (parameters != null) {
to keep our validation proccess consize pls use the validator here to validate
the parameter class and place constraints annotation on the
VdcActionPatameterBase.
e.g
public interface PreRun { }
VdcActionParameterBase.java
@Pattern(regexp = ValidationUtils.NO_SPECIAL_CHARACTERS, message =
"VALIDATION.TAGS.INVALID_COR_ID", group = PreRun.class)
String correlatijonId
and in evaluateCorrelationId
ValidationUtils.getValidator.validate(parameters,PreRun.class)
checkout CommandBase.validateInputs to see result handling
--
To view, visit http://gerrit.ovirt.org/1949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I130bb71c8e6c2a4709f3cd08e031380ca5252da4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
