Moti Asayag has posted comments on this change.
Change subject: core: Add correlation support to ovirt-engine
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 538: if (parameters != null) {
That's a good idea.
Will send a patch for refactoring ValidationUtils so it could be used here and
add validations for the correlation-id.
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log.java
Line 22: log.debug(addCorrelationIdToMessage(arg0), arg1);
debugFormat calls the debug method, so it shares same behaviour as debug.
same for infoFormat and info and the rest.
Line 171: private Object addCorrelationIdToMessage(Object o) {
Done
--
To view, visit http://gerrit.ovirt.org/1949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I130bb71c8e6c2a4709f3cd08e031380ca5252da4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
