Maor Lipchuk has posted comments on this change.

Change subject: core: Add correlation support to ovirt-engine
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log.java
Line 171:     private Object addCorrelationIdToMessage(Object o) {
Please change the object name to meaningful name, maybe logMessage
 Consider changing the method name to something more general, maybe 
addPrefixToLogMessage, it might be used for other purposes in the future.

--
To view, visit http://gerrit.ovirt.org/1949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I130bb71c8e6c2a4709f3cd08e031380ca5252da4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to