Michael Kublin has posted comments on this change.
Change subject: core: Add correlation support to ovirt-engine
......................................................................
Patch Set 3: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java
Line 322: if (correlationyId != null) {
Please move ThreadLocalParamsContainer.setCorrelationId to CommandBase (look
how these implemented there)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/job/ExecutionHandler.java
Line 46: private static final List<Class<?>> validationGroups =
why u need ArryayList here? Arrays.asList is not enought
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MultipleActionsRunner.java
Line 113: public void run() {
Validation actually done here in asynchronous way, so the monitoring also
should be done here
Line 164: if (command.getReturnValue().getCanDoAction()) {
why not set correlationId inside constructor commandBase
--
To view, visit http://gerrit.ovirt.org/1949
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I130bb71c8e6c2a4709f3cd08e031380ca5252da4
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
