Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing new command hierarchy
......................................................................
Patch Set 20: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 643: private void removeVmImages() {
Why is this method needed here? Each son command is responsible for removing
it's own images, so I don't think this should be here.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 118: protected void logInfo(String title,Object... parts){
Need to remove this method probably
--
To view, visit http://gerrit.ovirt.org/2299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f4abd569a8a620ca9657d4c472bb7b59a57429
Gerrit-PatchSet: 20
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
