Mike Kolesnik has posted comments on this change.
Change subject: DO NOT SUBMIT core: Introducing new command hierarchy
......................................................................
Patch Set 23: (8 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java
Line 63: protected void removeVmRelatedEntitiesFromDb() {
Why copy & paste instead of calling super.remove in the end (after images
remove)?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 645: protected DiskImage
getDiskImageToRemoveByParam(VdcActionParametersBase param) {
Maybe better throw a NotImplementedException?
Also when I think about this, seems more like a static method than a regular
one.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java
Line 246: protected Guid ConcreteCreateTask(AsyncTaskCreationInfo
asyncTaskCreationInfo, VdcActionType parentCommand) {
Why did you add this method here?
Line 333: protected DiskImage cloneAndUpdateDiskImage(Guid
newImageGuid,DiskImage srcDiskImage, DiskImageBase updateDiskImageBase) {
What are these methods? Seem unused
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
Line 37: public class CreateSnapshotCommand<T extends
ImagesActionsParametersBase> extends BaseCreateImageCommand<T> {
Why was this command changed?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToSnapshotCommand.java
Line 33
Why delete the annotation?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateSnapshotFromTemplateParameters.java
Line 5: public class CreateSnapshotFromTemplateParameters extends
ImagesActionsParametersBase implements java.io.Serializable {
Why add this implements clause?
Line 31: public void setVmId(Guid value) {
Why did you change to public?
--
To view, visit http://gerrit.ovirt.org/2299
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f4abd569a8a620ca9657d4c472bb7b59a57429
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
