Juan Hernandez has posted comments on this change. Change subject: core: Adds missing 3rd party dependencies as modules ......................................................................
Patch Set 1: According to your definition and as we can write code like this in Java (and it is quite common): String name = ...; Class clazz = Class.forName(name); Object instance = clazz.newInstance(); instance.... Then we need to include all possible classes in the world as runtime dependencies. That is obviously wrong. Even if a class appears in an "import" statement of one of your dependencies that doesn't make it a runtime dependency. This is what happens in this case, xz, for example, is a build dependency of commons-compress, but as we don't use the xz support of commons-compress we will never use xz. Same for the others. On the other hand the fact that a class doesn't appear in an "import" statement doesn't mean that it isn't a runtime dependency, as it can be dynamically loaded as I explained before. Runtime dependencies are different (not even a subset) of the dependencies calculated by "mvn dependency:tree". Trying to preserve that is wrong. In this particular case is particularly wrong because those three dependencies aren't used at all. -- To view, visit http://gerrit.ovirt.org/20048 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I35cc0d983010b4e0ab7ca4cea15a80a051fe9254 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
