Alon Bar-Lev has posted comments on this change. Change subject: tools: support snmp trap as a notification method. ......................................................................
Patch Set 15: (4 comments) minor notes. http://gerrit.ovirt.org/#/c/22909/15/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/snmp/SNMPEventSender.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/snmp/SNMPEventSender.java: Line 75: new OID(trapOID).append(3), Line 76: new OctetString(auditLogEvent.getLogTime().toString()))); Line 77: CommunityTarget target = new CommunityTarget(); Line 78: final String[] split = AuditLogEventSubscriber.getMethodAddress().split(":"); Line 79: target.setAddress(new UdpAddress(split[0] + "/" + (split.length > 1 ? split[1] : 162))); why is the loop of sending to multiple managers is not here? Line 80: target.setCommunity(new OctetString(prop.getProperty(NotificationProperties.SNMP_COMMUNITY))); Line 81: target.setVersion(SnmpConstants.version2c); Line 82: target.setRetries(2); Line 83: target.setTimeout(5000); Line 79: target.setAddress(new UdpAddress(split[0] + "/" + (split.length > 1 ? split[1] : 162))); Line 80: target.setCommunity(new OctetString(prop.getProperty(NotificationProperties.SNMP_COMMUNITY))); Line 81: target.setVersion(SnmpConstants.version2c); Line 82: target.setRetries(2); Line 83: target.setTimeout(5000); I still do not understand these settings regarding udp. Line 84: snmp.send(v2pdu, target); Line 85: final EventSenderResult eventSenderResult = new EventSenderResult(); Line 86: eventSenderResult.setSent(true); Line 87: return eventSenderResult; http://gerrit.ovirt.org/#/c/22909/15/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in: Line 124: # SNMP_FILTER_MODE=exclude|include Line 125: SNMP_FILTER_MODE=exclude Line 126: Line 127: # A whitespace separated events list. Line 128: SNMP_FILTER="" no need for "" Line 129: Line 130: # Notice by default all events are sent (exclude ""). Line 131: Line 132: #----------------------------------# Line 126: Line 127: # A whitespace separated events list. Line 128: SNMP_FILTER="" Line 129: Line 130: # Notice by default all events are sent (exclude ""). remove this comment? Line 131: Line 132: #----------------------------------# Line 133: # Engine Monitoring Configuration: # Line 134: #----------------------------------# -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
