mooli tayer has posted comments on this change. Change subject: tools: support snmp trap as a notification method. ......................................................................
Patch Set 15: (1 comment) http://gerrit.ovirt.org/#/c/22909/15/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/snmp/SNMPEventSender.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/sender/snmp/SNMPEventSender.java: Line 75: new OID(trapOID).append(3), Line 76: new OctetString(auditLogEvent.getLogTime().toString()))); Line 77: CommunityTarget target = new CommunityTarget(); Line 78: final String[] split = AuditLogEventSubscriber.getMethodAddress().split(":"); Line 79: target.setAddress(new UdpAddress(split[0] + "/" + (split.length > 1 ? split[1] : 162))); > the logic should change, there was only one mail server so it was ok in the This class should only be about implementing traps sending. Logic about different subscribers and events do not belong here. If you state specific concerns (The code is inefficient / The architecture is wrong) I can address them and maybe find a better solution. NotificationService is in charge for collecting and notifying different subscribers. Line 80: target.setCommunity(new OctetString(prop.getProperty(NotificationProperties.SNMP_COMMUNITY))); Line 81: target.setVersion(SnmpConstants.version2c); Line 82: target.setRetries(2); Line 83: target.setTimeout(5000); -- To view, visit http://gerrit.ovirt.org/22909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
