mooli tayer has posted comments on this change.

Change subject: tools: support snmp trap as a notification method.
......................................................................


Patch Set 15:

(2 comments)

http://gerrit.ovirt.org/#/c/22909/15/packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in
File packaging/services/ovirt-engine-notifier/ovirt-engine-notifier.conf.in:

Line 124: # SNMP_FILTER_MODE=exclude|include
Line 125: SNMP_FILTER_MODE=exclude
Line 126: 
Line 127: # A whitespace separated events list.
Line 128: SNMP_FILTER=""
> no need for ""
Done
Line 129: 
Line 130: # Notice by default all events are sent (exclude "").
Line 131: 
Line 132: #----------------------------------#


Line 126: 
Line 127: # A whitespace separated events list.
Line 128: SNMP_FILTER=""
Line 129: 
Line 130: # Notice by default all events are sent (exclude "").
> remove this comment?
Done
Line 131: 
Line 132: #----------------------------------#
Line 133: # Engine Monitoring Configuration: #
Line 134: #----------------------------------#


-- 
To view, visit http://gerrit.ovirt.org/22909
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0cd22d022ae535f45e046b09a2cbfadd837b465c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin PeÅ™ina <[email protected]>
Gerrit-Reviewer: mooli tayer <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to