Oved Ourfali has posted comments on this change. Change subject: packaging: setup: move customization of authentication to property file ......................................................................
Patch Set 1: Overall I think this approach contradicts a bit with the way bean properties should be filled. Not an expert in this one, so adding Yair to comment on that. Anyway, I understand the value of having this configuration externally, so I'd create a new Class holding these properties, creating an instance of it from the file, and using it in the createUrlConnection method, passing what's needed to other internal methods, if needed. What do you think? -- To view, visit http://gerrit.ovirt.org/23537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
