Oved Ourfali has posted comments on this change. Change subject: packaging: setup: move customization of authentication to property file ......................................................................
Patch Set 2: Code-Review+1 I didn't say the solution is to leave things as is. Just suggested to extract the configuration to another class. but that can be done in a different patch in the future. I'm okay with the current change. -- To view, visit http://gerrit.ovirt.org/23537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
