Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: move customization of authentication to property file ......................................................................
Patch Set 2: Verified+1 > Yair - due to urgency I've accepted that, but please also have a look and let > me know if it requires any changes. Hi, I do not want a compromise, I want the best solution. Having configuration within the war is incorrect for enterprise packaging, this change is a sync to enterprise and engine model. Had we deployed the war via the J2EE deployment, maybe I would have accepted embedded settings, if these could have been modified via the J2EE management console. Alon -- To view, visit http://gerrit.ovirt.org/23537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da Gerrit-PatchSet: 2 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
