Oved Ourfali has posted comments on this change. Change subject: packaging: setup: move customization of authentication to property file ......................................................................
Patch Set 1: Just wanted to say that I think such properties should usually be filled in the bean definition, in applicationContext-security-web.xml file. however, I understand why you want to get them from an external source. Perhaps I'm wrong about that (that's why I cc-ed Yair), but if I'm not, then perhaps you should create a new ConnectionProperties (or whatever) class, which will contain all the connection-relevant properties (url, ssl-stuff, etc.), and just use that instead of having separate properties in the main PreFilter class. -- To view, visit http://gerrit.ovirt.org/23537 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib8503fd98fdba775c62e038b953e8100244ec8da Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
