Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 107: # to check if the engine is up. Line 108: # Maybe in the future we can just rely on a Line 109: # not authenticated health API URL Line 110: self._ovirtsdk_api.API( Line 111: url='https://localhost:{port}/ovirt-engine/api'.format( you cannot use localhost without insecure parameter... not sure what is the exact name. Line 112: port=self.environment[ Line 113: osetupcons.ConfigEnv.PUBLIC_HTTPS_PORT Line 114: ], Line 115: ), Line 120: password=self.environment[ Line 121: osetupcons.ConfigEnv.ADMIN_PASSWORD Line 122: ], Line 123: ca_file=osetupcons.FileLocations. Line 124: OVIRT_ENGINE_PKI_ENGINE_CA_CERT, our convention for this is: ca_file=( osetupcons.FileLocations. OVIRT_ENGINE_PKI_ENGINE_CA_CERT ), to make clear where parameter begins and where it ends. Line 125: ) Line 126: isUp = True Line 127: except: Line 128: time.sleep(self.ENGINE_DELAY) Line 123: ca_file=osetupcons.FileLocations. Line 124: OVIRT_ENGINE_PKI_ENGINE_CA_CERT, Line 125: ) Line 126: isUp = True Line 127: except: please do not swallow exceptions, empty except will also except exit exceptions and others. Line 128: time.sleep(self.ENGINE_DELAY) Line 129: if not isUp: Line 130: raise RuntimeError(_('Engine unreachable')) Line 131: Line 183: def _closeup(self): Line 184: self._waitEngineUp() Line 185: self.logger.debug('Connecting to the Engine') Line 186: engine_api = self._ovirtsdk_api.API( Line 187: url='https://localhost:{port}/ovirt-engine/api'.format( again... this should have failed or we have a bug in sdk :) Line 188: port=self.environment[osetupcons.ConfigEnv.PUBLIC_HTTPS_PORT], Line 189: ), Line 190: username='{user}@{domain}'.format( Line 191: user=osetupcons.Const.USER_ADMIN, -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
