Alon Bar-Lev has posted comments on this change. Change subject: Avoiding legacy health servlet usage ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/26090/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/all-in-one/vdsm.py: Line 180: osetupcons.Stages.APACHE_RESTART, Line 181: ), Line 182: ) Line 183: def _closeup(self): Line 184: self._waitEngineUp() you can return the object from this function and use it in following code... no reason to reconstruct. Line 185: self.logger.debug('Connecting to the Engine') Line 186: engine_api = self._ovirtsdk_api.API( Line 187: url='https://localhost:{port}/ovirt-engine/api'.format( Line 188: port=self.environment[osetupcons.ConfigEnv.PUBLIC_HTTPS_PORT], -- To view, visit http://gerrit.ovirt.org/26090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48225db31b57f70687887f4c06fb923648bfe9f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: David Caro <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
