Alon Bar-Lev has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: > Adding is easy, but if you wan't to alter something that's read from file and > you don't know content of the file (for example names of appenders), that's > harder. the content of which file? log4j? it should contain no appender. all you do when you get --log-file parameter is add file appender to root logger. let's not over engineer this. -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
