Martin Peřina has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: > q. ConsoleAppender is file appender to stdout, right? ConsoleAppender and FileAppender are children WriterAppender, I will have to look to source what's the exact difference. > if we do not use logging to print messages, there is no reason to add a > default appender. I thought that info messages are going to console. Well, currently log.* goes to log and System.out.println goes to console, so completely different approach. >2. > AFAIK, it's hard to mix programmatic and file based configuration in log4j >are you sure? can't you add appender into running configuration? I am almost >sure I've done so in past. Adding is easy, but if you wan't to alter something that's read from file and you don't know content of the file (for example names of appenders), that's harder. -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
