Martin Peřina has posted comments on this change. Change subject: tools: remove log4j usage from engine-config ......................................................................
Patch Set 1: >All ok, but I do not understand: >> 4) Add --log4j-config which will contain user defined configuration and >> which won't be altered by us at all > why does it conflicts with 1, 2, 3? we just load this instead of whatever in > jar. Well, if user defines it's own log4j.xml why wouldn't he define appender(s) in this file and use --log-file for this instead? -- To view, visit http://gerrit.ovirt.org/26305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc4eadac817e0527d1286e277b4500f83526c6f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
