Sandro Bonazzola has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/27524/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/__init__.py: Line 1: # Line 2: # ovirt-engine-setup -- ovirt engine setup Line 3: # Copyright (C) 2014 Red Hat, Inc. 2013-2014 Line 4: # Line 5: # Licensed under the Apache License, Version 2.0 (the "License"); Line 6: # you may not use this file except in compliance with the License. Line 7: # You may obtain a copy of the License at http://gerrit.ovirt.org/#/c/27524/2/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 72: currentVersion = odwhcons.Const.RPM_VERSION Line 73: minVersion, minMinor = self._parseVersionString(minimalVersion) Line 74: curVersion, curMinor = self._parseVersionString(currentVersion) Line 75: if ( Line 76: (float(curVersion) != float(minVersion)) or > Shouldn't it be Simone: it won't be compatible with any version < 3 and we can't ensure we'll be compatible with version > 4. I think != is enough here. Line 77: (int(curMinor) < int(minMinor)) Line 78: ): Line 79: raise RuntimeError( Line 80: _( -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
