Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/27524/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 68: minimalVersion = statement.getVdcOption( Line 69: name='MinimalETLVersion', Line 70: ownConnection=True, Line 71: ) Line 72: currentVersion = odwhcons.Const.RPM_VERSION not sure why we need this, please do not use the rpm resources Line 73: minVersion, minPatchLevel = self._parseVersionString(minimalVersion) Line 74: curVersion = "%s.%s" % ( Line 75: odwhcons.Const.MAJOR_VERSION, Line 76: odwhcons.Const.MINOR_VERSION Line 73: minVersion, minPatchLevel = self._parseVersionString(minimalVersion) Line 74: curVersion = "%s.%s" % ( Line 75: odwhcons.Const.MAJOR_VERSION, Line 76: odwhcons.Const.MINOR_VERSION Line 77: ) oh, you parse the hmmm... confusing... please extract major, minor, fix from the etl version then compare it via integers with your constants. there is no need for string comperation. Line 78: curPatchLevel = odwhcons.Const.PATCH_LEVEL Line 79: if ( Line 80: (float(curVersion) != float(minVersion)) or Line 81: (int(curPatchLevel) < int(minPatchLevel)) -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
