Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/27524/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 39: pattern=r""" Line 40: ^ Line 41: (?P<version>(\d+\.\d+)) Line 42: \. Line 43: (?P<minor>(\d+)) this is fix not minor Line 44: (?P<extra>.*) Line 45: $ Line 46: """, Line 47: ) Line 68: minimalVersion = statement.getVdcOption( Line 69: name='MinimalETLVersion', Line 70: ownConnection=True, Line 71: ) Line 72: currentVersion = odwhcons.Const.RPM_VERSION please do not assume anything regarding rpm, it is wrong assumption that rpm is available. you have PACKAGE_VERSION, and also, I suggest not to use this and split to minor/major at build instead of parsing. Line 73: minVersion, minMinor = self._parseVersionString(minimalVersion) Line 74: curVersion, curMinor = self._parseVersionString(currentVersion) Line 75: if ( Line 76: (float(curVersion) != float(minVersion)) or -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
