Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: Force a minimal ETL version ......................................................................
Patch Set 4: (2 comments) http://gerrit.ovirt.org/#/c/27524/4/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-dwh/core/check_etl.py: Line 43: (?P<patch_level>(\d+)) Line 44: (?P<extra>.*) Line 45: $ Line 46: """, Line 47: ) you do not need to parse now Line 48: Line 49: def _parseVersionString(self, string): Line 50: matcher = self._RE_VERSION.match(string) Line 51: return matcher.group('version'), matcher.group('patch_level') http://gerrit.ovirt.org/#/c/27524/4/version.mak File version.mak: Line 5: # Fix release is manually specified, Line 6: # increment after releasing/branching Line 7: MAJOR_VERSION=3 Line 8: MINOR_VERSION=5 Line 9: PATCH_LEVEL=0 I prefer all version related variable will have VERSION_ prefix, in this case: VERSION_MAJOR VERSION_MINOR VERSION_FIX not sure what patch level is... but you can: VERSION_PATCH_LEVEL Line 10: VERSION=$(MAJOR_VERSION).$(MINOR_VERSION).$(PATCH_LEVEL) Line 11: Line 12: # Milestone is manually specified, Line 13: # example for ordering: -- To view, visit http://gerrit.ovirt.org/27524 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iccef80d1397c6b66ad5a8440e59af238b42416a7 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
