Yevgeny Zaspitsky has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); Line 36: this.qoSType = qoSType; > validation in ctor.... don't like it. otherwise you allow an object be initialized in a wrong way or spread the validation over the code in every place you refer to the member. Line 37: } Line 38: /** Line 39: * @return object's type Line 40: */ Line 112: return false; Line 113: if (getClass() != obj.getClass()) Line 114: return false; Line 115: BaseQos other = (BaseQos) obj; Line 116: if (id == null) { > I reject any use of un-generated equals method. IMHO that isn't an excuse for producing sub-optimal code. Move to IntelliJ or find a way to produce good code using Eclipse. Line 117: if (other.id != null) Line 118: return false; Line 119: } else if (!id.equals(other.id)) Line 120: return false; -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
