Moti Asayag has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 46: * Shows object'ss limits according to type Line 47: * Line 48: * @return Line 49: */ Line 50: public abstract String getString(); > I'm not sure I fully understand you comment, but if you're about having her +1 for yevgeny's comment regarding UI: if there is an intention to share getString() with UI for presenting it to the user in any view - it should be blocked: 1. Not multi-lingual. 2. Coupling between engine to ui logic (logging to engine.log via presenting to user). 2.1. Will have to be addressed once UI moves on top of rest entities. Line 51: Line 52: /** Line 53: * Check whether specific derived values are equal. Line 54: * -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
