Yevgeny Zaspitsky has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (5 comments) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 27: @Size(min = 1, max = BusinessEntitiesDefinitions.GENERAL_NAME_SIZE, message = "QOS_NAME_TOO_LONG") Line 28: @ValidI18NName(message = "QOS_NAME_INVALID") Line 29: private String name; Line 30: Line 31: private BaseQos() { > yes. for GWT. Agreed. I wasn't aware of that limitation Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); Line 36: this.qoSType = qoSType; > if(qosType == null) { IllegalArgumentException Line 37: } Line 38: /** Line 39: * @return object's type Line 40: */ Line 42: return qoSType; Line 43: } Line 44: Line 45: /** Line 46: * Shows object'ss limits according to type > javadoc is always good. you didn't understand why I added getString(), will Sure, javadoc is good! However what's "object'ss limits" are? What this method returns? Line 47: * Line 48: * @return Line 49: */ Line 50: public abstract String getString(); Line 46: * Shows object'ss limits according to type Line 47: * Line 48: * @return Line 49: */ Line 50: public abstract String getString(); > getString() will be used later on for view and aggregation; I'd rather save I'm not sure I fully understand you comment, but if you're about having here some view logic, then here isn't the place for that. View logic should be in the UI layer. Line 51: Line 52: /** Line 53: * Check whether specific derived values are equal. Line 54: * Line 54: * Line 55: * @param other Line 56: * @return are equals Line 57: */ Line 58: public abstract boolean equalValues(BaseQos other); > yes. we check for equal values in other places, that's why it's separated ( VmNetworkInterface, VmNic, NetworkInterface do not define such method. They implement equals and hashCode that call their super implementation. IMHO that's better (intuitive) way. Line 59: Line 60: /** Line 61: * @return derived values hash code Line 62: */ -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
