Gilad Chaplik has posted comments on this change. Change subject: common: introduce qos package, and storage qos ......................................................................
Patch Set 5: (8 comments) http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/BaseQos.java: Line 14: /** Line 15: * Base abstract class for QoS objects Line 16: * Line 17: */ Line 18: public abstract class BaseQos extends IVdcQueryable implements BusinessEntity<Guid>, Serializable { > if you rely on other de-facto standards - this class should have probably b don't know what happens in other places. the class is Base Quality of Service, hence BaseQos Line 19: private static final long serialVersionUID = 1122772549710787678L; Line 20: private Guid id = Guid.Empty; Line 21: private QosType qoSType; Line 22: Line 20: private Guid id = Guid.Empty; Line 21: private QosType qoSType; Line 22: Line 23: @NotNull(message = "ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID") Line 24: private Guid storagePoolId; > storagePool is an old notation. would you mind changing it to dataCenterId Done Line 25: Line 26: @NotNull(message = "QOS_NAME_NOT_NULL") Line 27: @Size(min = 1, max = BusinessEntitiesDefinitions.GENERAL_NAME_SIZE, message = "QOS_NAME_TOO_LONG") Line 28: @ValidI18NName(message = "QOS_NAME_INVALID") Line 32: } Line 33: Line 34: public BaseQos(QosType qoSType) { Line 35: this(); Line 36: this.qoSType = qoSType; > IllegalArgumentException Done Line 37: } Line 38: /** Line 39: * @return object's type Line 40: */ Line 42: return qoSType; Line 43: } Line 44: Line 45: /** Line 46: * Shows object'ss limits according to type > Sure, javadoc is good! Done Line 47: * Line 48: * @return Line 49: */ Line 50: public abstract String getString(); Line 46: * Shows object'ss limits according to type Line 47: * Line 48: * @return Line 49: */ Line 50: public abstract String getString(); > +1 for yevgeny's comment regarding UI: if there is an intention to share ge 1) no-one said it will be used for UI. 2) toString() is called implicitly and I don't want to overload it (see getString impl in derived class). Line 51: Line 52: /** Line 53: * Check whether specific derived values are equal. Line 54: * Line 54: * Line 55: * @param other Line 56: * @return are equals Line 57: */ Line 58: public abstract boolean equalValues(BaseQos other); > VmNetworkInterface, VmNic, NetworkInterface do not define such method. They please don't give example of code you've written/in-charge of, having said that, I feel this is more intuitive. Line 59: Line 60: /** Line 61: * @return derived values hash code Line 62: */ http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/qos/QosType.java: Line 7: public enum QosType implements Identifiable { Line 8: STORAGE(1); Line 9: Line 10: private int value; Line 11: private static final HashMap<Integer, QosType> valueToStatus = new HashMap<Integer, QosType>(); > could you reduce the type to Map ? sure. copy/paste it from somewhere you probably didn't review. Line 12: Line 13: static { Line 14: for (QosType status : values()) { Line 15: valueToStatus.put(status.getValue(), status); http://gerrit.ovirt.org/#/c/27093/5/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 1092: ACTION_TYPE_FAILED_GLUSTER_VOLUME_CANNOT_STOP_REBALANCE_IN_PROGRESS= Cannot ${action} ${type}. Rebalance is running on the volume ${volumeName} in cluster ${vdsGroup}. Line 1093: ACTION_TYPE_FAILED_GLUSTER_OPERATION_INPROGRESS=Cannot ${action} ${type}. Gluster operation is in progress in cluster. Please try again. Line 1094: ACTION_TYPE_FAILED_TAG_ID_REQUIRED=Cannot ${action} ${type}. Tag ID is required. Line 1095: Line 1096: ACTION_TYPE_FAILED_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. > would you mind setting context to the values ? only "values" is too vague w will open a bug once the patch is merged. Line 1097: Line 1098: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} ${type}. All three values are needed in order to define QoS on each network directions. Line 1099: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action} ${type}. Negative values are not allowed. Line 1100: ACTION_TYPE_FAILED_NETWORK_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} ${type}. Values are out of range. -- To view, visit http://gerrit.ovirt.org/27093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a9af59277b5055453159f002f19046c0051d8ff Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kobi Ianko <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Yevgeny Zaspitsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
