Allon Mureinik has posted comments on this change.
Change subject: core: RegisterVdsQuery -removed CanDoAction()
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java
Line 35: // get correct return value type
I'd leave this private and use getReturnValue in the extending classes.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 96: protected boolean validateInputs() {
optional: consider replacing "result=false" with "return false" and get rid of
all the if-elses.
Line 99: returnValue.setExceptionString("");
use getReturnValue instead of returnValue - throughtout this function.
--
To view, visit http://gerrit.ovirt.org/5631
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c33cc1af4127da44fecd74559124090a535f574
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
