Ayal Baron has posted comments on this change. Change subject: core: RegisterVdsQuery -removed CanDoAction() ......................................................................
Patch Set 4: I would prefer that you didn't submit this (7 inline comments) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java Line 98: boolean result = super.validateInputs(); you could return early here and move the entire function left. Line 106: result = false; same here Line 111: result = false; and here Line 116: result = false; and here Line 121: result = false; ... Line 130: result = false; ... Line 133: return result; if you change the above then this should be return true -- To view, visit http://gerrit.ovirt.org/5631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33cc1af4127da44fecd74559124090a535f574 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
