Allon Mureinik has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
Line 101: final StorageFormatType targetFormat
= getStoragePool().getStoragePoolFormatType();
Line 102:
Line 103: if (domain.getStorageFormat() !=
targetFormat) {
Line 104: log.infoFormat("Updating storage
domain {0} (type {1}) to format {2}",
Line 105: getStorageDomain().getId(),
sdType, targetFormat);
If upgrade fails - what can the user do with the detached pool?
is there any gaurentee it's still usable?
Line 106:
domain.setStorageFormat(targetFormat);
Line 107: sdStatDao.update(domain);
Line 108: }
Line 109: }
--
To view, visit http://gerrit.ovirt.org/7445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2424b80ba914f3d83ec99f442970bc103232563a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
