Federico Simoncelli has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
Line 43:
Line 44: @Override
Line 45: protected void executeCommand() {
Line 46: if (getStorageDomain() != null) {
Line 47: if (getStoragePool().getstatus() ==
StoragePoolStatus.Uninitialized) {
I also need to deal with this flow. (Eg: at the moment you can create a dc 3.1
out of a master domain V1/V2 without upgrading it. Wrong).
Line 48: StoragePoolWithStoragesParameter parameters = new
StoragePoolWithStoragesParameter(getStoragePool(),
Line 49: new java.util.ArrayList<Guid>(
Line 50: java.util.Arrays.asList(new Guid[] {
getStorageDomain().getId() })),
Line 51: getParameters().getSessionId());
--
To view, visit http://gerrit.ovirt.org/7445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2424b80ba914f3d83ec99f442970bc103232563a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
