Federico Simoncelli has posted comments on this change.

Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
Line 152:                         }
Line 153:                         // for data centers >= 3.1 we enforce the 
domain version to V3
Line 154:                         if 
(getStoragePool().getcompatibility_version().compareTo(Version.v3_1) >= 0) {
Line 155:                             final storage_domain_static staticDomain 
= storageDomain.getStorageStaticData();
Line 156:                             
staticDomain.setStorageFormat(StorageFormatType.V3);
That is done only once (when you select the master domain, I want to do it for 
all the domains).
Line 157:                             
getDbFacade().getStorageDomainStaticDAO().update(staticDomain);
Line 158:                         }
Line 159:                         
storageDomain.setstorage_pool_id(getStoragePool().getId());
Line 160:                         if (masterStorageDomain == null


--
To view, visit http://gerrit.ovirt.org/7445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2424b80ba914f3d83ec99f442970bc103232563a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to