Federico Simoncelli has posted comments on this change.
Change subject: core: Allow to attach V1 and V2 data domains to a DC 3.1
......................................................................
Patch Set 4: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainToPoolCommand.java
Line 92: if (sdType == StorageDomainType.Master) {
Line 93: calcStoragePoolStatusByDomainsStatus();
Line 94: }
Line 95:
Line 96: // upgrade the domain format to the
storage pool format
Yes
Line 97: if (sdType == StorageDomainType.Data ||
sdType == StorageDomainType.Master) {
Line 98: final StorageDomainStaticDAO sdStatDao
= getDbFacade().getStorageDomainStaticDAO();
Line 99: final storage_domain_static domain =
sdStatDao.get(getStorageDomain().getId());
Line 100: final StorageFormatType targetFormat
= getStoragePool().getStoragePoolFormatType();
Line 93: calcStoragePoolStatusByDomainsStatus();
Line 94: }
Line 95:
Line 96: // upgrade the domain format to the
storage pool format
Line 97: if (sdType == StorageDomainType.Data ||
sdType == StorageDomainType.Master) {
Done
Line 98: final StorageDomainStaticDAO sdStatDao
= getDbFacade().getStorageDomainStaticDAO();
Line 99: final storage_domain_static domain =
sdStatDao.get(getStorageDomain().getId());
Line 100: final StorageFormatType targetFormat
= getStoragePool().getStoragePoolFormatType();
Line 101:
Line 94: }
Line 95:
Line 96: // upgrade the domain format to the
storage pool format
Line 97: if (sdType == StorageDomainType.Data ||
sdType == StorageDomainType.Master) {
Line 98: final StorageDomainStaticDAO sdStatDao
= getDbFacade().getStorageDomainStaticDAO();
Done
Line 99: final storage_domain_static domain =
sdStatDao.get(getStorageDomain().getId());
Line 100: final StorageFormatType targetFormat
= getStoragePool().getStoragePoolFormatType();
Line 101:
Line 102: if (domain.getStorageFormat() !=
targetFormat) {
Line 102: if (domain.getStorageFormat() !=
targetFormat) {
Line 103: log.infoFormat("Updating storage
domain {0} (type {1}) to format {2}",
Line 104: getStorageDomain().getId(),
sdType, targetFormat);
Line 105:
domain.setStorageFormat(targetFormat);
Line 106: sdStatDao.update(domain);
Unrelated (and possibly incorrect)
Line 107: }
Line 108: }
Line 109:
Line 110: getCompensationContext().stateChanged();
--
To view, visit http://gerrit.ovirt.org/7445
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2424b80ba914f3d83ec99f442970bc103232563a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
