Juan Hernandez has posted comments on this change. Change subject: packaging: Find and check JVM during setup (#834436) ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/fedora/setup/engine-setup.py Line 1921: Line 1922: # It passed all the checks, so it is valid JVM: Line 1923: return True Line 1924: Line 1925: def checkJdk(jvmPath): Correct, JDK cannot be installed without JRE, and JAVA_HOME/bin/java exists both in JDK and JRE. The only thing we try to do here is select JRE instead of JDK if both are installed. The reason is that JRE is more likely to stay around than JDK. In Fedora, for example, our package requires the JRE, but not the JDK. If the JDK happens to be installed before installing ovirt-engine then it we could select it instead of the JRE. Then, if the JDK is removed, the engine would stop working. That is what I try to avoid. Line 1926: # We assume that this JVM path has already been checked and that it Line 1927: # contains a valid JVM, so we only need to check that it also Line 1928: # contains a Java compiler: Line 1929: javaCompiler = os.path.join(jvmPath, "bin", "javac") -- To view, visit http://gerrit.ovirt.org/7549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
