Alex Lourie has posted comments on this change. Change subject: packaging: Find and check JVM during setup (#834436) ......................................................................
Patch Set 5: Looks good to me, but someone else must approve (1 inline comment) ack with minor comment. .................................................... File packaging/fedora/setup/engine-setup.py Line 20: import output_messages Line 21: import common_utils as utils Line 22: import engine_validators as validate Line 23: import random Line 24: import subprocess This is no longer needed :-) Line 25: import tempfile Line 26: from optparse import OptionParser, OptionGroup Line 27: from setup_controller import Controller Line 28: from Cheetah.Template import Template -- To view, visit http://gerrit.ovirt.org/7549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
