Alon Bar-Lev has posted comments on this change. Change subject: packaging: Find and check JVM during setup (#834436) ......................................................................
Patch Set 3: (1 inline comment) .................................................... File packaging/fedora/setup/engine-setup.py Line 1921: Line 1922: # It passed all the checks, so it is valid JVM: Line 1923: return True Line 1924: Line 1925: def checkJdk(jvmPath): OK. Sorry, not used to this primitive (again...), system should allow to distinguish... will not give examples. Line 1926: # We assume that this JVM path has already been checked and that it Line 1927: # contains a valid JVM, so we only need to check that it also Line 1928: # contains a Java compiler: Line 1929: javaCompiler = os.path.join(jvmPath, "bin", "javac") -- To view, visit http://gerrit.ovirt.org/7549 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib279ea8111825ec35a25f9ba6ee37b481ed4354f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
