Oved Ourfali has posted comments on this change. Change subject: tools: Adding Reload Configs Implementation (#825671) ......................................................................
Patch Set 7: (2 inline comments) see comments. .................................................... File backend/manager/tools/engine-config/src/main/resources/engine-config Line 33: printf "\t-h, --help\n" Line 34: printf "\t\tdisplay this help and exit.\n" Line 35: printf "\n" Line 36: printf "### Notes: \n" Line 37: printf "### 1. Passwords: password can be set in interacetive mode ie:\n" s/interacetive/interactive Line 38: printf "### engine-config -s PasswordEntry=interactive\n" Line 39: printf "### or via file with one of the following options:\n" Line 40: printf "### engine-config -s PasswordEntry --admin-pass-file=/tmp/mypass\n" Line 41: printf "### engine-config -s PasswordEntry=/tmp/mypass\n" .................................................... File backend/manager/tools/engine-config/src/main/resources/engine-config.conf Line 2: Line 3: Line 4: # Data source files Line 5: jbossDataSourceFile=/usr/local/jboss-as-7.1.1.Final/standalone/configuration/standalone.xml Line 6: jbossLoginConfigFile=/usr/local/jboss-as-7.1.1.Final/standalone/configuration/standalone.xml I guess this change shouldn't be in, isn't it? Line 7: log4jConfPath=/etc/ovirt-engine/engine-config/log4j.xml Line 8: Line 9: # Data structure Line 10: configTable=vdc_options -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
