Muli Salem has posted comments on this change. Change subject: tools: Adding Reload Configs Implementation (#825671) ......................................................................
Patch Set 9: Using the ovirt-engine-sdk is not an option since the reload action is not available there at this stage (since it is only a tech preview, I assume mpaternak can elaborate on this issue). Using curl forces us to display the password openly, which AFAIK is problematic. The java solution seems reasonable, and the patch size may be a bit confusing since a major part of it is refactoring existing code, and another major part of it is building the URL itself which needs to be built regardless of the solution, unless you request it from the user. In addition, creating a new tool seems to me a bit less user oriented, and not sure we want to add the ovirt-engine-sdk to the engine-config dependencies. -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
