Alon Bar-Lev has posted comments on this change. Change subject: tools: Adding Reload Configs Implementation (#825671) ......................................................................
Patch Set 9: Hello Muli, Thank you for the response. Adding the reload to the SDK should be trivial, it is a code change just like this one, just it is at reusable tool. Using curl with netrc file does not expose password to the process list. We discuss that this tool can be run also using a parameter to engine-config, so there is no change in this regard. The patch size is not confusing it is implementation that can be dropped entirely in favour of few lines in shell or python. Thank you for the response, Alon -- To view, visit http://gerrit.ovirt.org/4951 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b9e790d7a8386359edfd62172df1078da033e91 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Muli Salem <[email protected]> Gerrit-Reviewer: Ori Liel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
